Improve wording around expire + transact#1590
Merged
zuiderkwast merged 5 commits intoredis:masterfrom Jun 25, 2021
Merged
Conversation
zuiderkwast
suggested changes
Jun 25, 2021
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Nice!
Are we going to add another note when redis/redis#9068 is solved too? A note for that would looks something like
- In Redis versions before x.y.z, if a watched key expires between MULTI and EXEC, it does not cause a transaction to be aborted. More on this
Contributor
Author
|
Yeah, I would add another note for redis/redis#9068, it seems like an important caveat. |
zuiderkwast
approved these changes
Jun 25, 2021
oranagra
reviewed
Jun 27, 2021
Closed
enjoy-binbin
pushed a commit
to enjoy-binbin/redis-doc
that referenced
this pull request
Aug 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifying transaction documentation after we fixed the expire bug.