API documentation of EXPIRETIME and PEXPIRETIME commands#1582
Merged
oranagra merged 9 commits intoredis:masterfrom Jun 15, 2021
Merged
API documentation of EXPIRETIME and PEXPIRETIME commands#1582oranagra merged 9 commits intoredis:masterfrom
oranagra merged 9 commits intoredis:masterfrom
Conversation
oranagra
approved these changes
Jun 1, 2021
zuiderkwast
reviewed
Jun 1, 2021
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Looks good in general. A few nits.
Co-authored-by: Viktor Söderqvist <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]>
zuiderkwast
approved these changes
Jun 2, 2021
Contributor
yoav-steinberg
left a comment
yoav-steinberg
left a comment
There was a problem hiding this comment.
Minor English fix.
Co-authored-by: yoav-steinberg <[email protected]>
oranagra
approved these changes
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add API documentation for
EXPIRETIMEandPEXPIRETIMEcommands introduced in this PR: redis/redis#8474