New ZRANGESTORE and ZRANGE new args, deprecate others#1482
New ZRANGESTORE and ZRANGE new args, deprecate others#1482oranagra merged 5 commits intoredis:masterfrom
Conversation
oranagra
force-pushed
the
zrangestore
branch
2 times, most recently
from
92bd6cc to
f3ad6cd
Compare
|
@itamarhaber i merged your PR (oranagra#1) and added another commit, please have a look. I see not all the content from the ZRANGEBYSCORE and ZRANGEBYLEX pages was copied into the ZRANGE page. i guess it's a good compromise, doesn't include all the details of the separate pages, but also better than what i did, adding at least some basic info, while still also referring to the other page do you think that's good to go now? |
itamarhaber
left a comment
itamarhaber
left a comment
There was a problem hiding this comment.
I'm comfortable with it as is.
My intent was to include as many details as possible about each variant, without too much clutter. Other than patterns, I hope I included everything.
WRT to missing patterns: once we overhaul the docs, I think patterns should be moved out of specific commands' man pages, and into a "pattern/use case" topic thing.
2 participants
i'm not very comfortable with how this came out.
documenting all the nuances and instructions of BYSCORE / BYLEX / BYRANK in one page can make it quite complex.
instead i added a note to refer to the documentation of the deprecated commands for details (which sounds like a bad idea).
maybe that's a hint that this change is all wrong?
i.e. there are a lot of details about inclusive / exclusive searches and how the lexicographic ordering works, maybe unifying them into one command is wrong?