Added documentation regarding error statistics (redis/redis#8217)#1472
Merged
itamarhaber merged 1 commit intoredis:masterfrom Jan 3, 2021
Merged
Added documentation regarding error statistics (redis/redis#8217)#1472itamarhaber merged 1 commit intoredis:masterfrom
itamarhaber merged 1 commit intoredis:masterfrom
Conversation
oranagra
reviewed
Dec 28, 2020
| For each command type, the following line is added: | ||
|
|
||
| * `cmdstat_XXX`: `calls=XXX,usec=XXX,usec_per_call=XXX` | ||
| * `cmdstat_XXX`: `calls=XXX,usec=XXX,usec_per_call=XXX,rejected_calls=XXX,failed_calls=XXX` |
Member
There was a problem hiding this comment.
@itamarhaber I know we don't currently document which info fields were added in each version, but maybe considering that this is a dict field we should? or maybe we should for all?
Contributor
Author
There was a problem hiding this comment.
@oranagra @itamarhaber should we add it as a note? example: Note: rejected_calls and failed_calls are available since XX
Member
There was a problem hiding this comment.
Generally, we document the history, but in INFO's case this has never been done. Better late than never? I don't think this applies in this case so we can merge as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR documents the added features in redis/redis#8217 ( the new errorstats section and a new global error counter ).