Skip to content

Documentation update for new ZADD GT and LT options#1397

Merged
oranagra merged 6 commits intoredis:masterfrom
alexronke-channeladvisor:zadd-gt-lt-docs
Sep 30, 2020
Merged

Documentation update for new ZADD GT and LT options#1397
oranagra merged 6 commits intoredis:masterfrom
alexronke-channeladvisor:zadd-gt-lt-docs

Conversation

@alexronke-channeladvisor
Copy link
Contributor

Per the pull request in the main redis repository:
redis/redis#7818

This is an update to the documentation describing the GT and LT options for the ZADD command.

Copy link
Member

@oranagra oranagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itamarhaber do we want for 6.2 to release it? or merge it as soon as the code is in redis's unstable?

* Text edits
* Uses the `@history` tag
@itamarhaber
Copy link
Member

Thanks for this @alexronke-channeladvisor - I made a couple of edits but looks good all in all.

@oranagra since this is an extension of an existing command, and because we're pretty sure it will be in the upcoming v6.2.0, I think we can merge once in unstable.

@alexronke-channeladvisor
Copy link
Contributor Author

Thanks for this @alexronke-channeladvisor - I made a couple of edits but looks good all in all.

@oranagra since this is an extension of an existing command, and because we're pretty sure it will be in the upcoming v6.2.0, I think we can merge once in unstable.

I put "6.2" in the documentation description because the PR had been flagged with that milestone. Is there a better way to describe that?

@oranagra
Copy link
Member

@alexronke-channeladvisor the marking of 6.2 in your PR was correct. we where trying to decide if it should be merged right now or wait.. we concluded it can be merged right now.

@oranagra oranagra merged commit e676d45 into redis:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants