resolve replication test timing sensitivity#9982
Merged
oranagra merged 1 commit intoredis:unstablefrom Dec 22, 2021
oranagra:fix_repl_test_timing
Merged
resolve replication test timing sensitivity#9982oranagra merged 1 commit intoredis:unstablefrom oranagra:fix_repl_test_timing
oranagra merged 1 commit intoredis:unstablefrom
oranagra:fix_repl_test_timing
Conversation
itamarhaber
approved these changes
Dec 22, 2021
Member
Author
oranagra
added a commit
that referenced
this pull request
Dec 22, 2021
issue started failing after #9878 was merged (made an exiting test more sensitive) looks like #9982 didn't help, tested this one and it seems to work better. this commit does two things: 1. reduce the extra delay i added earlier and instead add more keys, the effect no duration of replication is the same, but the intervals in which the server is responsive to the tcl client is higher. 2. improve the test infra to print context when assert_error fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue started failing after #9878 was merged (made an exiting test more sensitive)