Wait for asyn_loading to stop in short read test#9841
Merged
oranagra merged 1 commit intoredis:unstablefrom Nov 24, 2021
Merged
Wait for asyn_loading to stop in short read test#9841oranagra merged 1 commit intoredis:unstablefrom
asyn_loading to stop in short read test#9841oranagra merged 1 commit intoredis:unstablefrom
Conversation
In redis#9323, when `repl-diskless-load` is enabled and set to `swapdb`, if the master replication ID hasn't changed, we can load data-set asynchronously, and serving read commands during the full resync. In `diskless loading short read` test, after a loading successfully, we will wait for the loading to stop and continue the for loop. After the introduction of `async_loading`, we also need to check it. Otherwise the next loop will start too soon, may trigger a timing issue.
oranagra
approved these changes
Nov 24, 2021
hwware
pushed a commit
to hwware/redis
that referenced
this pull request
Dec 20, 2021
In redis#9323, when `repl-diskless-load` is enabled and set to `swapdb`, if the master replication ID hasn't changed, we can load data-set asynchronously, and serving read commands during the full resync. In `diskless loading short read` test, after a loading successfully, we will wait for the loading to stop and continue the for loop. After the introduction of `async_loading`, we also need to check it. Otherwise the next loop will start too soon, may trigger a timing issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9323, when
repl-diskless-loadis enabled and set toswapdb,if the master replication ID hasn't changed, we can load data-set
asynchronously, and serving read commands during the full resync.
In
diskless loading short readtest, after a loading successfully,we will wait for the loading to stop and continue the for loop.
After the introduction of
async_loading, we also need to check it.Otherwise the next loop will start too soon, may trigger a timing issue.