Add --large-memory flag for REDIS_TEST to enable tests that consume more than 100mb#9784
Merged
oranagra merged 1 commit intoredis:unstablefrom Nov 16, 2021
Merged
Conversation
oranagra
approved these changes
Nov 16, 2021
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
i'm not a big fan of the dependency of testhelp.h, we could have instead just add another boolean argument.
but since it was already there (only used in sds.c), and since we do have a framework that requires all tests main methods to have the same signature, i'll accept it.
p.s. i thought you'll add this commit as part of the other PR, but since so many unrelated files have changed, maybe we can indeed merge this first and then build on top of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is for #9776.
Added the
--large-memoryflag toREDIS_TEST, and integrated the old--accurateflag intotesthelp.h.