Skip to content

Increase test timeout in valgrind runs#9767

Merged
oranagra merged 1 commit intoredis:unstablefrom
oranagra:valgrind_ci_timeout
Nov 10, 2021
Merged

Increase test timeout in valgrind runs#9767
oranagra merged 1 commit intoredis:unstablefrom
oranagra:valgrind_ci_timeout

Conversation

@oranagra
Copy link
Member

@oranagra oranagra commented Nov 10, 2021

We saw some tests sporadically time out on valgrind (namely the ones
from #9323).

Increasing valgrind timeout from 20 mins to 40 mins in CI.
And fixing an outdated help message.

@oranagra
Increase test timeout in valgrind runs
904aa9f 
We saw some tests sporadically time out on valgrind (namely the ones
from #9323).

Increasing valgrind timeout from 20 mins to 40 mins in CI.
And fixing an outdated help message.
@oranagra oranagra requested a review from yossigo November 10, 2021 16:22
@oranagra oranagra mentioned this pull request Nov 10, 2021
Merged
@oranagra
Copy link
Member Author

oranagra commented Nov 10, 2021

note, the timeout in the test suite is about the last time the main test process got any message from it's worker processes.
so in valgrind we run the tests with --clients 1, which increases the chances a slow test will get a timeout.
i also saw that on successful valgrind runs in GH actions, the integration/replication unit took 2743 seconds.
so it could be that one of the tests inside it took more than 1200 seconds and then got a timeout.
since the problem was sporadic, i assume the timeout was borderline.

@oranagra oranagra merged commit 978eadb into redis:unstable Nov 10, 2021
@oranagra oranagra deleted the valgrind_ci_timeout branch November 10, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yossigo yossigo yossigo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oranagra @yossigo