Fix diskless load handling on broken EOF marker#9752
Merged
oranagra merged 2 commits intoredis:unstablefrom Nov 9, 2021
Merged
Fix diskless load handling on broken EOF marker#9752oranagra merged 2 commits intoredis:unstablefrom
oranagra merged 2 commits intoredis:unstablefrom
Conversation
oranagra
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted by @oranagra here: #9323 (comment)
During diskless replication, the check for broken EOF mark is misplaced and should be earlier.
Now we do not swap db, we do proper cleanup and correctly raise module events on this kind of failure.
This issue existed prior to #9323, but before, the side effect was not restoring backup and not raising the correct module events on this failure.