Fix failing cluster tests#9707
Merged
oranagra merged 4 commits intoredis:unstablefrom Oct 31, 2021
oranagra:fix-failing-cluster-tests
Merged
Fix failing cluster tests#9707oranagra merged 4 commits intoredis:unstablefrom oranagra:fix-failing-cluster-tests
oranagra merged 4 commits intoredis:unstablefrom
oranagra:fix-failing-cluster-tests
Conversation
madolson
approved these changes
Oct 31, 2021
Contributor
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
This seems like a more correct solution to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failures introduced by #9695 which was an attempt to solve failures introduced by #9679.
An alternative to #9703 (i didn't like the extra argument to kill_instance).
Reverting #9695.
Instead of stopping AOF on all terminations, stop it only on the two which need it.
Do it as part of the test rather than the infra (it was add that kill_instance used
Rto communicate to the instance)
Note that the original purpose of these tests was to trigger a crash, but that upsets
valgrind so in redis 6.2 i changed it to use SIGTERM, so i now rename the tests
(remove "kill" and "crash").
Also add some colors to failures, and the word "FAILED" so that it's searchable.
And solve a semi-related race condition in 14-consistency-check.tcl