Fixed cluster test where node was waiting to disable AOF#9703
Closed
madolson wants to merge 2 commits intoredis:unstablefrom
Closed
Fixed cluster test where node was waiting to disable AOF#9703madolson wants to merge 2 commits intoredis:unstablefrom
madolson wants to merge 2 commits intoredis:unstablefrom
Conversation
oranagra
approved these changes
Oct 31, 2021
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
How come it passed when I run it locally? (multiple times).
Btw, it could be that there's a node that's both doing the initial rewrite, and also paused.
Maybe we should change the order, and unpause first?
Or maybe for these tests we wanna pass an argument so that it uses SIGKILL like it used to do in 6.0?
Member
|
ohh, i see it didn't pass on my machine, but sine there's nothing colored in red on the last page, i didn't notice the failure. |
Member
oranagra
added a commit
that referenced
this pull request
Oct 31, 2021
Fix failures introduced by #9695 which was an attempt to solve failures introduced by #9679. And alternative to #9703 (i didn't like the extra argument to kill_instance). Reverting #9695. Instead of stopping AOF on all terminations, stop it only on the two which need it. Do it as part of the test rather than the infra (it was add that kill_instance used `R` to communicate to the instance) Note that the original purpose of these tests was to trigger a crash, but that upsets valgrind so in redis 6.2 i changed it to use SIGTERM, so i now rename the tests (remove "kill" and "crash"). Also add some colors to failures, and the word "FAILED" so that it's searchable. And solve a semi-related race condition in 14-consistency-check.tcl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests were getting delayed since there were waiting for the command to disable AOF to go through while it was being killed. However, the node was paused since the next part of the test relied on the node being unreachable from the replica, so the waiting to execute the AOF command broke the test timing.
https://github.com/redis/redis/actions/runs/1403850622