Fix timing issue in replication buffer test#9697
Merged
oranagra merged 1 commit intoredis:unstablefrom Oct 29, 2021
Merged
Conversation
Introduced in redis#9166
oranagra
approved these changes
Oct 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in #9166
In daily CI https://github.com/redis/redis/runs/4028904569?check_suite_focus=true, I found this log.
I think executing 'debug digest' on master which has many keys costs much time (especially in valgrind), default
repl-timeoutis 60s, and i notice last test spent more than 80 seconds, so i think this causes that replica1 and replica2 disconnect with master.