Modify mem_usage2 module callback to enable to take sample_size argument#9612
Merged
oranagra merged 4 commits intoredis:unstablefrom Oct 17, 2021
Merged
Conversation
oranagra
reviewed
Oct 7, 2021
…f complex module types Adding `sample_size` arg to enable module to compute approximately key size based on `sample_size` sampled nested values only. Existing mem_usage2 api can be changed, due to the fact that it was introduced lately in e0cd3ad, but was not released yet.
fadidahanna
force-pushed
the
mem_usage_for_complex_module_type
branch
from
5d6d9e5 to
407d26a
Compare
oranagra
reviewed
Oct 10, 2021
oranagra
changed the title
oranagra
added
state:to-be-merged
Member
|
@redis/core-team please approve an additional argument to a new module callback not yet released. |
Member
|
Fixes #4177 |
itamarhaber
approved these changes
Oct 10, 2021
sundb
reviewed
Oct 12, 2021
Co-authored-by: sundb <[email protected]>
oranagra
approved these changes
Oct 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for approximating size computation of complex module types.
Note that the mem_usage2 callback is new and has not been released yet, which is why we can modify it.