Fix stream sanitization for non-int first value#9553
Merged
oranagra merged 1 commit intoredis:unstablefrom Sep 26, 2021
oranagra:validate-stream
Merged
Fix stream sanitization for non-int first value#9553oranagra merged 1 commit intoredis:unstablefrom oranagra:validate-stream
oranagra merged 1 commit intoredis:unstablefrom
oranagra:validate-stream
Conversation
This was recently broken in #9321 when we validated stream IDs to be integers but did that after to the stepping next record instead of before.
oranagra
added
the
state:to-be-merged
Member
Author
|
@sundb @itamarhaber FYI |
itamarhaber
approved these changes
Sep 26, 2021
Member
itamarhaber
left a comment
itamarhaber
left a comment
There was a problem hiding this comment.
@oranagra thanks - I checked and this fixes the issue I've encountered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was recently broken in #9321 when we validated stream IDs to be
integers but did that after to the stepping next record instead of before.