Fix callReplyParseCollection memleak when use AutoMemory#9446
Fix callReplyParseCollection memleak when use AutoMemory#9446oranagra merged 2 commits intoredis:unstablefrom chenyang8094:fix-module-reply-memleak
Conversation
|
@chenyang8094 nice catch, I guess you mean that the |
|
Yes, let's make sure to cover as much as we can in these code paths with tests for auto-memory issues. |
@MeirShpilraien Yes, there is leak in RM_CreateStringFromCallReply. |
Test has been added. @MeirShpilraien @oranagra |
|
Thanks @chenyang8094 , looks good. |
|
I have a test failure in daily ci. Looking at the git logs it could be caused by this pr. |
When parsing an array type reply,
ctxwill be lost when recursively parsing its elements, which will cause a memory leak in automemory mode.This is a result of the changes in #9202