Sanitize dump payload: fix double free after insert dup nodekey to stream rax and returns 0#9399
Merged
oranagra merged 2 commits intoredis:unstablefrom Aug 20, 2021
Merged
Conversation
…tream rax and returns 0
sundb
changed the title
sundb
force-pushed
the
fuzzer-stream-listpack
branch
from
244796b to
a01d5a0
Compare
sundb
changed the title
oranagra
approved these changes
Aug 20, 2021
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
…ream rax and returns 0 (redis#9399)
oranagra
added
the
release-notes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is found by
corrupt-dump-fuzzingtest.When using raxInsert to insert a duplicate
nodekey, it will overwrite the old data, and finally, return 0.This will result in both
decrRefCount(o)andlpFree(lp)which will free the listpack.