Delay to discard cached master when full synchronization#9398
Merged
oranagra merged 4 commits intoredis:unstablefrom Sep 9, 2021
Merged
Delay to discard cached master when full synchronization#9398oranagra merged 4 commits intoredis:unstablefrom
oranagra merged 4 commits intoredis:unstablefrom
Conversation
Contributor
|
cool. I had the exact same idea before |
oranagra
added
the
state:to-be-merged
oranagra
reviewed
Aug 22, 2021
ShooterIT
force-pushed
the
delay-cache-master
branch
from
d65fa4a to
d824494
Compare
ShooterIT
commented
Aug 25, 2021
oranagra
approved these changes
Aug 29, 2021
oranagra
added
the
release-notes
oranagra
reviewed
Aug 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, once replica need to start full synchronization with master, it will discard cached master whatever full synchronization is failed or not. I think the cached master still is valid if failing to full synchronization, since replica's data is not changed during waiting data snapshot from master. Now we discard cached master only when transferring RDB is finished and start to change data space, this make replica could start partial resynchronization with another new master if new master is failed during full synchronization.