More generic crash report for unsupported archs#9385
More generic crash report for unsupported archs#9385oranagra merged 3 commits intoredis:unstablefrom
Conversation
Following compilation warnings on s390x.
| #define NOT_SUPPORTED() do {\ | ||
| UNUSED(uc);\ | ||
| return NULL;\ | ||
| } while(0) |
There was a problem hiding this comment.
why not just always do UNUSED(uc), and have a single return NULL at the end?
There was a problem hiding this comment.
If I add a return NULL; at the end then when the arch is known it'll compile to two returns:
return (void*)uc->stuff;
return NULL;Which will generate more warnings.
There was a problem hiding this comment.
ohh.. unreachable code...
well, ok. let's keep your version..
| #define NOT_SUPPORTED() do {\ | ||
| UNUSED(uc);\ | ||
| serverLog(LL_WARNING,\ | ||
| " Dumping of registers not supported for this OS/arch");\ | ||
| } while(0) |
There was a problem hiding this comment.
same here, i'd be ok with just adding UNUSED(uc).
the the very fact the register dump is missing seems enough (the log print is unnecessary).
There was a problem hiding this comment.
Was trying to keep the previous behavior. If we scrap the logging then we can just add UNUSED(uc); since the there's no return value in this function. Should we scrap the logging?
Following compilation warnings on s390x.
2 participants
Specifically handles build warnings on s390x