Added additional validation for cluster SETSLOT#9360
Merged
madolson merged 1 commit intoredis:unstablefrom Aug 12, 2021
Merged
Conversation
yossigo
approved these changes
Aug 12, 2021
Contributor
Do we need to make the same changes to ADDSLOTS / DELSLOTS? These commands should only work on the primary. edit: oops, sorry, i just realize this is what #12282 does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis cluster SETSLOT [importing|migrating] is intended to migrate data from one primary to another. In this case these two nodes should agree that each other are primaries before continuing. This just adds another layer of validation so that end users get the error sooner that they may have copied the wrong node ID.
Follow up from #3450 (comment).
Note the other PR also had a FIX for SETSLOT node which you may call by default across the entire cluster to force acknowledging ownership of a slot, and someone might not know the state.