Improvements to corrupt payload sanitization#9321
Merged
oranagra merged 10 commits intoredis:unstablefrom Aug 5, 2021
oranagra:sanitization_issues
Merged
Improvements to corrupt payload sanitization#9321oranagra merged 10 commits intoredis:unstablefrom oranagra:sanitization_issues
oranagra merged 10 commits intoredis:unstablefrom
oranagra:sanitization_issues
Conversation
…which start with 0xff
prevoiusly only plain and sds strings were protected, i forgot about robj ones
this code was already fixed in #8887 so i grabbed the code from there see 4a8f57c6c
Co-authored-by: Yossi Gottlieb <[email protected]>
yossigo
previously approved these changes
Aug 5, 2021
oranagra
added
the
release-notes
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
Recently we found two issues in the fuzzer tester: redis#9302 redis#9285 After fixing them, more problems surfaced and this PR (as well as redis#9297) aims to fix them. Here's a list of the fixes - Prevent an overflow when allocating a dict hashtable - Prevent OOM when attempting to allocate a huge string - Prevent a few invalid accesses in listpack - Improve sanitization of listpack first entry - Validate integrity of stream consumer groups PEL - Validate integrity of stream listpack entry IDs - Validate ziplist tail followed by extra data which start with 0xff Co-authored-by: sundb <[email protected]>
oranagra
added a commit
that referenced
this pull request
Sep 26, 2021
This was recently broken in #9321 when we validated stream IDs to be integers but did that after to the stepping next record instead of before.
Merged
oranagra
added a commit
that referenced
this pull request
Oct 4, 2021
Recently we found two issues in the fuzzer tester: #9302 #9285 After fixing them, more problems surfaced and this PR (as well as #9297) aims to fix them. Here's a list of the fixes - Prevent an overflow when allocating a dict hashtable - Prevent OOM when attempting to allocate a huge string - Prevent a few invalid accesses in listpack - Improve sanitization of listpack first entry - Validate integrity of stream consumer groups PEL - Validate integrity of stream listpack entry IDs - Validate ziplist tail followed by extra data which start with 0xff Co-authored-by: sundb <[email protected]> (cherry picked from commit 0c90370)
oranagra
added a commit
that referenced
this pull request
Oct 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently we found two issues in the fuzzer tester: #9302 #9285
After fixing them, more problems surfaced and this PR (as well as #9297) aims to fix them.
Here's a list of the fixes
joint effort with @sundb