Skip to content

Fix undefined behavior in sdsll2str#9310

Closed
sundb wants to merge 1 commit intoredis:unstablefrom
sundb:fix-sdsll2str
Closed

Fix undefined behavior in sdsll2str#9310
sundb wants to merge 1 commit intoredis:unstablefrom
sundb:fix-sdsll2str

Conversation

@sundb
Copy link
Collaborator

@sundb sundb commented Aug 3, 2021

Reproduct

Change Makefile:

gcov:
	$(MAKE) REDIS_CFLAGS="-DREDIS_TEST -fprofile-arcs -ftest-coverage -DCOVERAGE_TEST" REDIS_LDFLAGS="-fprofile-arcs -ftest-coverage"

run:

make gcov
redis-server test sds

At c951c3ee5a12110f1c0c1270c45ab663c04e0f77里, ll2string was fixed with the same problem, but not modified to sds.

@enjoy-binbin
Copy link
Contributor

I actually had a same old pr... #8910

@sundb
Copy link
Collaborator Author

sundb commented Aug 3, 2021

@enjoy-binbin Then you reopen it, I close it.

@enjoy-binbin
Copy link
Contributor

ohh. Sure, i reopen it. thanks

@sundb sundb deleted the fix-sdsll2str branch August 10, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants