Add debug config flag to print certain config values on engine crash#9304
Merged
madolson merged 6 commits intoredis:unstablefrom Aug 5, 2021
Merged
Add debug config flag to print certain config values on engine crash#9304madolson merged 6 commits intoredis:unstablefrom
madolson merged 6 commits intoredis:unstablefrom
Conversation
oranagra
reviewed
Aug 2, 2021
oranagra
added
the
state:to-be-merged
oranagra
approved these changes
Aug 5, 2021
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
…edis#9304) Add debug config flag to print certain config values on engine crash
enjoy-binbin
added a commit
to enjoy-binbin/redis
that referenced
this pull request
Feb 4, 2022
Change the sentinel config file to a directory in SENTINEL SET test. So it will now fail on the `rename` in `rewriteConfigOverwriteFile`. The test used to set the sentinel config file permissions to `000` to simulate failure. But it fails on centos7 / freebsd / alpine. (introduced in redis#10151) Other changes: 1. More error messages after the config rewrite failure. 2. Modify arg name `force_all` in `rewriteConfig` to `force_write`. (was rename in redis#9304) 3. Fix a typo in debug quicklist-packed-threshold, then -> than. (redis#9357)
oranagra
pushed a commit
that referenced
this pull request
Feb 4, 2022
Change the sentinel config file to a directory in SENTINEL SET test. So it will now fail on the `rename` in `rewriteConfigOverwriteFile`. The test used to set the sentinel config file permissions to `000` to simulate failure. But it fails on centos7 / freebsd / alpine. (introduced in #10151) Other changes: 1. More error messages after the config rewrite failure. 2. Modify arg name `force_all` in `rewriteConfig` to `force_write`. (was rename in #9304) 3. Fix a typo in debug quicklist-packed-threshold, then -> than. (#9357)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to mark config variables to be printed in their rewrite syntax on engine crashes. I added the initial couple I think would be useful for debugging, but
Sort of address #6734, which was opened by @itamarhaber, but I changed the wording to describe the intent of the flag (for debugging information) instead of be instructive in what the config does.