fix zslGetRank bug in dead-code#9246
Merged
oranagra merged 1 commit intoredis:unstablefrom Jul 22, 2021
oranagra:fix_skiplist_deadcode_bug
Merged
fix zslGetRank bug in dead-code#9246oranagra merged 1 commit intoredis:unstablefrom oranagra:fix_skiplist_deadcode_bug
oranagra merged 1 commit intoredis:unstablefrom
oranagra:fix_skiplist_deadcode_bug
Conversation
Contributor
|
interesting... |
Member
Author
|
@enjoy-binbin i agree, but i also seem to remember this or something similar being discussed recently, and i can't locate it (are you aware of something?). |
Contributor
|
No, I just saw this pr, it was interesting, and then happened to revisit the implementation of insertion... I created a new pr: #9249 |
Contributor
yossigo
approved these changes
Jul 22, 2021
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
This fixes an issue with zslGetRank which will happen only if the skiplist data stracture is added two entries with the same element name, this can't happen in redis zsets (we use dict), but in theory this is a bug in the underlaying skiplist code. Fixes redis#3081 and redis#4032 Co-authored-by: minjian.cai <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with zslGetRank which will happen only if the
skiplist data stracture is added two entries with the same element name,
this can't happen in redis zsets (we use dict), but in theory this is a
bug in the underlaying skiplist code.
Fixes #3081 and #4032