Change return value type for ZPOPMAX/MIN in RESP3#8981
Merged
oranagra merged 2 commits intoredis:unstablefrom Jun 16, 2021
Merged
Change return value type for ZPOPMAX/MIN in RESP3#8981oranagra merged 2 commits intoredis:unstablefrom
oranagra merged 2 commits intoredis:unstablefrom
Conversation
oranagra
added
release-notes
jhelbaum
force-pushed
the
fix_8824_zrange_return_type
branch
from
14590fa to
90f5a8d
Compare
oranagra
reviewed
Jun 13, 2021
…PMIN in RESP3 When using RESP3, ZPOPMAX/ZPOPMIN should return nested arrays for consistency with other commands.
jhelbaum
force-pushed
the
fix_8824_zrange_return_type
branch
from
9d1bf41 to
69ce548
Compare
oranagra
approved these changes
Jun 13, 2021
madolson
approved these changes
Jun 14, 2021
oranagra
added
the
state:to-be-merged
yossigo
approved these changes
Jun 15, 2021
oranagra
changed the title
oranagra
added
the
breaking-change
Member
|
we decided to backport this to 6.0 and 6.2 mainly because RESP3 isn't yet heavily used, so the chance this will do some breakage is low, and on the other hand if some new app will start using resp3 on a recent release of 6.0 / 6.2, we prefer that i'll have that change from the get go. |
oranagra
pushed a commit
that referenced
this pull request
Jul 21, 2021
When using RESP3, ZPOPMAX/ZPOPMIN should return nested arrays for consistency with other commands (e.g. ZRANGE). We do that only when COUNT argument is present (similarly to how LPOP behaves). for reasoning see #8824 (comment) This is a breaking change only when RESP3 is used, and COUNT argument is present! (cherry picked from commit 7f34202) (cherry picked from commit caaad2d)
oranagra
pushed a commit
that referenced
this pull request
Jul 21, 2021
When using RESP3, ZPOPMAX/ZPOPMIN should return nested arrays for consistency with other commands (e.g. ZRANGE). We do that only when COUNT argument is present (similarly to how LPOP behaves). for reasoning see #8824 (comment) This is a breaking change only when RESP3 is used, and COUNT argument is present! (cherry picked from commit 7f34202)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
When using RESP3, ZPOPMAX/ZPOPMIN should return nested arrays for consistency with other commands (e.g. ZRANGE). We do that only when COUNT argument is present (similarly to how LPOP behaves). for reasoning see redis#8824 (comment) This is a breaking change only when RESP3 is used, and COUNT argument is present!
This was referenced Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using RESP3, ZPOPMAX/ZPOPMIN should return nested arrays for consistency
with other commands (e.g. ZRANGE).
We do that only when COUNT argument is present (similarly to how LPOP behaves).
for reasoning see #8824 (comment)
This is a breaking change only when RESP3 is used, and COUNT argument is present!