Count zmalloc size of aof buf into overhead#8970
Merged
oranagra merged 1 commit intoredis:unstablefrom May 20, 2021
Merged
Conversation
oranagra
reviewed
May 20, 2021
oranagra
added
the
state:to-be-merged
oranagra
approved these changes
May 20, 2021
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
In theory we should have used zmalloc_usable_size, but it may be slower, and now after redis#7875, there's no actual difference. So this change isn't making a dramatic change. Co-authored-by: Oran Agra <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5453 we use sds allocated size to get aof buf occupation size, but actually we need to use zmalloc size of it. I find @oranagra have fixed another one in #7864