Extend freeSlotsToKeysMapAsync and freeTrackingRadixTreeAsync to check LAZYFREE_THRESHOLD.#8969
Merged
oranagra merged 2 commits intoredis:unstablefrom May 30, 2021
Conversation
…k LAZYFREE_THRESHOLD.
enjoy-binbin
changed the title
oranagra
previously approved these changes
May 20, 2021
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
LGTM.
maybe we can add some comment saying why we use numnodes and not numele (i.e. because this rax has only keys, and no values.
also, maybe we wanna use this opportunity to fix the stats, but i'm not sure if 1 numnodes or numele is better, so waiting to hear more feedback before i merge.
@madolson maybe you'll have an opinion. see some considerations here
oranagra
added
the
state:to-be-merged
oranagra
reviewed
May 20, 2021
enjoy-binbin
force-pushed
the
extend_check_lazyfree_threshold
branch
from
e963e07 to
c6a6e23
Compare
oranagra
approved these changes
May 30, 2021
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
…k LAZYFREE_THRESHOLD. (redis#8969) Without this fix, FLUSHALL ASYNC would have freed these in a background thread, even if they didn't contain many elements (unlike how it works with other structures), which could be inefficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, FLUSHALL ASYNC would have freed these in a background thread,
even if they didn't contain many elements (unlike how it works with other structures), which could be inefficient.
see some considerations #8258 (comment)