fix redis-benchmark to ignore unsupported configs#8916
Merged
oranagra merged 2 commits intoredis:unstablefrom May 6, 2021
oranagra:fix-benchmark-on-re
Merged
fix redis-benchmark to ignore unsupported configs#8916oranagra merged 2 commits intoredis:unstablefrom oranagra:fix-benchmark-on-re
oranagra merged 2 commits intoredis:unstablefrom
oranagra:fix-benchmark-on-re
Conversation
Redis Enterprise supports the CONFIG GET command, but it replies with am empty array since the save and appendonly configs are not supported. before this fix redis-benchmark would segfault for trying to access the error string on an array type reply. see #8869
oranagra
added
the
state:to-be-merged
yoav-steinberg
suggested changes
May 6, 2021
Contributor
yoav-steinberg
left a comment
yoav-steinberg
left a comment
There was a problem hiding this comment.
I think there's still an issue here. See inline comment.
Co-authored-by: yoav-steinberg <[email protected]>
yossigo
approved these changes
May 6, 2021
madolson
pushed a commit
to madolson/redis
that referenced
this pull request
May 12, 2021
Redis Enterprise supports the CONFIG GET command, but it replies with am empty array since the save and appendonly configs are not supported. before this fix redis-benchmark would segfault for trying to access the error string on an array type reply. see redis#8869
Merged
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
Redis Enterprise supports the CONFIG GET command, but it replies with am empty array since the save and appendonly configs are not supported. before this fix redis-benchmark would segfault for trying to access the error string on an array type reply. see redis#8869
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis Enterprise supports the CONFIG GET command, but it replies with am
empty array since the save and appendonly configs are not supported.
before this fix redis-benchmark would segfault for trying to access the
error string on an array type reply.
see #8869