Add GetAbsExpire/SetAbsExpire for module#8564
Merged
oranagra merged 1 commit intoredis:unstablefrom Mar 24, 2021
chenyang8094:abs-expire
Merged
Add GetAbsExpire/SetAbsExpire for module#8564oranagra merged 1 commit intoredis:unstablefrom chenyang8094:abs-expire
oranagra merged 1 commit intoredis:unstablefrom
chenyang8094:abs-expire
Conversation
Contributor
|
I think the new APIs are useful, ping @redis/core-team get more suggestions. |
oranagra
previously approved these changes
Mar 10, 2021
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
i agree with the usefulness of this API.
i have some concern about the details, but on further thinking i think the current version may be ok.
oranagra
added
release-notes
oranagra
previously approved these changes
Mar 18, 2021
itamarhaber
previously approved these changes
Mar 18, 2021
yossigo
previously approved these changes
Mar 18, 2021
soloestoy
suggested changes
Mar 19, 2021
chenyang8094
dismissed stale reviews from yossigo, itamarhaber, and oranagra
via
63f475a
chenyang8094
requested review from
itamarhaber,
oranagra,
soloestoy and
yossigo
Add a check to ensure that the expire parameters in RM_SetExpire and RM_SetAbsExpire must be positive.
soloestoy
approved these changes
Mar 19, 2021
sundb
reviewed
Mar 19, 2021
oranagra
approved these changes
Mar 21, 2021
oranagra
added
the
state:to-be-merged
Merged
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
Add a check to ensure that the expire parameters in RM_SetExpire and RM_SetAbsExpire must be positive.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the
SET key value [PXAT <milliseconds-timestamp>], it is often necessary to set and get the absolute expire time of the key in the module. Otherwise I can only do it by this:Now i can do it by this:
At the same time, in the previous implementation of
RM_SetExpire, expire is not forced to be a positive value, so it is possible to get a value that conflicts with REDISMODULE_NO_EXPIRE(-1) inRM_GetExpire, so I Add a check to ensure that the expire parameters inRM_SetExpireandRM_SetAbsExpiremust be positive.