Allow stopped redis processes to be killed#8552
Merged
madolson merged 1 commit intoredis:unstablefrom Feb 24, 2021
Merged
Conversation
oranagra
approved these changes
Feb 24, 2021
Member
|
I assume you reproduced it and tested that the fix works.. |
Contributor
Author
|
@oranagra I did test it, I found it while writing the failover tests but forgot to submit it :) |
Contributor
Author
|
Just for completion sake, here was the local test I had: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a test fails while a node is stopped, we intercept the signal but since it's stopped it never exits until the timeout kills it. This just executes a continue signal to all nodes to cover that case, so tests exit more quickly.