Skip to content

Allow stopped redis processes to be killed#8552

Merged
madolson merged 1 commit intoredis:unstablefrom
madolson:unstable-dead-node
Feb 24, 2021
Merged

Allow stopped redis processes to be killed#8552
madolson merged 1 commit intoredis:unstablefrom
madolson:unstable-dead-node

Conversation

@madolson
Copy link
Contributor

If a test fails while a node is stopped, we intercept the signal but since it's stopped it never exits until the timeout kills it. This just executes a continue signal to all nodes to cover that case, so tests exit more quickly.

@oranagra
Copy link
Member

I assume you reproduced it and tested that the fix works..
In theory the order of the signals could be swapped..

@madolson
Copy link
Contributor Author

@oranagra I did test it, I found it while writing the failover tests but forgot to submit it :)

@madolson
Copy link
Contributor Author

Just for completion sake, here was the local test I had:

start_server {tags {"failover"}} {
    set node_0_pid [srv 0 pid]

    test {Stop a test and fail} {
        exec kill -SIGSTOP $node_0_pid
        assert_equal 1 0
    }
}

@madolson madolson merged commit c6f0ea2 into redis:unstable Feb 24, 2021
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Mar 2, 2021
@sundb sundb mentioned this pull request Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants