Fix wrong repldboff type which causes dropped replication in rare cases.#847
Merged
Fix wrong repldboff type which causes dropped replication in rare cases.#847
Conversation
antirez
added a commit
that referenced
this pull request
Dec 11, 2013
Fix wrong repldboff type which causes dropped replication in rare cases.
Contributor
|
Thanks! Merged. |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Aug 29, 2016
Fix wrong repldboff type which causes dropped replication in rare cases.
sundb
pushed a commit
to sundb/redis
that referenced
this pull request
Jul 28, 2025
…y allowed on primary (redis#847) Added an assertion to avoid incorrect usage of the network bytes out for replication code flow in slot stats computation. Signed-off-by: Harkrishn Patro <[email protected]>
minchopaskal
pushed a commit
to minchopaskal/redis
that referenced
this pull request
Oct 16, 2025
minor follow-ups for XXH3 specification (redis#750)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a 'long' offset to an 'off_t' sized data block is wrong when size is greater than 2GB and less than 4GB, on a 32-bit process. This results with replication being interrupted after transferring the first 2GB.