Fix crash on loading AOF with timed out script.#8284
Merged
oranagra merged 3 commits intoredis:unstablefrom Jan 4, 2021
Merged
Fix crash on loading AOF with timed out script.#8284oranagra merged 3 commits intoredis:unstablefrom
oranagra merged 3 commits intoredis:unstablefrom
Conversation
If AOF file contains a long Lua script that timed out, then the `evalCommand` calls `blockingOperationEnds` which sets` server.blocked_last_cron` to 0. later on, the AOF `whileBlockedCron` function asserts that this value is not 0. The fix allows nesting call to `blockingOperationStarts` and `blockingOperationEnds`. The issue was first introduce in this commit: 9ef8d2f
oranagra
reviewed
Jan 4, 2021
oranagra
reviewed
Jan 4, 2021
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
@MeirShpilraien you forgot to initialize the new member at startup.
Co-authored-by: Oran Agra <[email protected]>
Author
@oranagra thanks, done. |
oranagra
approved these changes
Jan 4, 2021
oranagra
added
the
release-notes
Merged
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Mar 2, 2021
If AOF file contains a long Lua script that timed out, then the `evalCommand` calls `blockingOperationEnds` which sets `server.blocked_last_cron` to 0. later on, the AOF `whileBlockedCron` function asserts that this value is not 0. The fix allows nesting call to `blockingOperationStarts` and `blockingOperationEnds`. The issue was first introduce in this commit: 9ef8d2f (Redis 6.2 RC1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If AOF file contains a long Lua script that timed out, then the
evalCommandcallsblockingOperationEndswhich setsserver.blocked_last_cronto 0. later on, the AOFwhileBlockedCronfunction asserts that this value is not 0.The fix allows nesting call to
blockingOperationStartsandblockingOperationEnds.The issue was first introduce in this commit: 9ef8d2f