Changes 'FROMLOC' to 'FROMLONLAT'#8190
Merged
oranagra merged 1 commit intoredis:unstablefrom Dec 14, 2020
Merged
Conversation
And formats style a tiniee-winiee bit
Member
|
LONLAT is also short for something else.. |
oranagra
approved these changes
Dec 14, 2020
Contributor
|
I agree |
yossigo
approved these changes
Dec 14, 2020
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Mar 2, 2021
And formats style a tiniee-winiee bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And formats style a tiniee-winiee bit
I found the "LOC" inconsistent with "MEMBER". One option is
FROMLOCATION, another isFROMCOORDSbut this - despite its lolwut-ness, helps me remember the correct (?) order of arguments and is somewhat consistent with the used terminology.Pinging @yangbodong22011