Skip to content

Fix redis-cli crash on nil invalidate messages.#8183

Merged
yossigo merged 1 commit intoredis:unstablefrom
yossigo:rediscli-resp3-push
Dec 13, 2020
Merged

Fix redis-cli crash on nil invalidate messages.#8183
yossigo merged 1 commit intoredis:unstablefrom
yossigo:rediscli-resp3-push

Conversation

@yossigo
Copy link
Collaborator

@yossigo yossigo commented Dec 13, 2020

This is a backport of redis/hiredis@b9b9f44.

@oranagra
Copy link
Member

@yossigo how did you find it? do we want a test?
@michael-grunder can you please confirm that this commit is independent and doesn't require any followup fixes or preparation to be brought.

@yossigo
Copy link
Collaborator Author

yossigo commented Dec 13, 2020

@oranagra Just trying out flushdb with RESP3 invalidations. I don't think it really deserves a test and the problem/fix is really trivial. @michael-grunder if you plan a hiredis bugfix release in the near future we may just as well pull it before 6.2.0 is out.

@yossigo yossigo merged commit 1e301ff into redis:unstable Dec 13, 2020
@yossigo yossigo deleted the rediscli-resp3-push branch December 13, 2020 20:11
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants