Several (mostly Solaris-related) cleanups#8171
Conversation
Useful for systems where GNU Make is 'gmake'.
Modifying CFLAGS/LDFLAGS directly resulted with make re-building the entire tree every time.
|
Calling @devnexen, I noticed you've recently provided some Solaris related fixes, would be happy if you can have a look at this! The starting point was I failed to build on a recent illumos, but now some tests still consistently fail around diskless replication. I don't have the bandwidth to deep dive into it (Solaris is not a priority to be honest) but it seems like it could be an issue with event ports not firing properly for a pipe that's used to communicate with the child process. |
|
quick look at your changes, the src/Makefile change makes the build fail as it their mix-ins 32 and 64 bits objects. What not keeping both FINAL_* and previous changes together ? Other than that non solaris changes sounds about right. |
src/atomicvar.h
Outdated
There was a problem hiding this comment.
can you tell me something about this change?
There was a problem hiding this comment.
This looks like some leftover from 9588331, resulting in failing to choose any atomicvar strategy with gcc on Solaris.
src/networking.c
Outdated
There was a problem hiding this comment.
i guess this line was added by mistake
src/util.c
Outdated
There was a problem hiding this comment.
let's trim that line, shouldn't be here.
tests/modules/Makefile
Outdated
There was a problem hiding this comment.
| # Compile flags for linux / osx |
tests/modules/Makefile
Outdated
There was a problem hiding this comment.
| else | |
| else /* Linux and Solaris */ |
Note that the exclusion of __sun seems to be historic and possibly related to non-GCC compilers.
yossigo
force-pushed
the
solaris-fixes
branch
from
e24251b to
d2e1df2
Compare
* Allow runtest-moduleapi use a different 'make', for systems where GNU Make is 'gmake'. * Fix issue with builds on Solaris re-building everything from scratch due to CFLAGS/LDFLAGS not stored. * Fix compile failure on Solaris due to atomicvar and a bunch of warnings. * Fix garbled log timestamps on Solaris.
3 participants
No description provided.