Skip to content

Add total_forks to INFO STATS#8155

Merged
oranagra merged 1 commit intoredis:unstablefrom
ShooterIT:total-forks
Dec 13, 2020
Merged

Add total_forks to INFO STATS#8155
oranagra merged 1 commit intoredis:unstablefrom
ShooterIT:total-forks

Conversation

@ShooterIT
Copy link
Member

Sometimes we want to know total forks of redis, that can help us analyze redis stability and some problems, because fork is much costly and may block server.

@oranagra oranagra added state:major-decision Requires core team consensus state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten labels Dec 8, 2020
@oranagra
Copy link
Member

oranagra commented Dec 8, 2020

@redis/core-team please approve a new info field (i think is useful indeed)

@itamarhaber itamarhaber added the state:needs-doc-pr requires a PR to redis-doc repository label Dec 8, 2020
@itamarhaber
Copy link
Member

Lgtm - @ShooterIT would you care to make a small pr to update the docs with this? (just add the field and description + update the history section in commands/info.md)

@yossigo yossigo added the approval-needed Waiting for core team approval to be merged label Dec 10, 2020
@oranagra oranagra merged commit e3ff414 into redis:unstable Dec 13, 2020
@ShooterIT ShooterIT deleted the total-forks branch December 14, 2020 05:58
@oranagra oranagra mentioned this pull request Jan 13, 2021
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval-needed Waiting for core team approval to be merged state:major-decision Requires core team consensus state:needs-doc-pr requires a PR to redis-doc repository state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants