@oranagra Thanks for your review, follow this tcl case, my original idea is as follows:

• The circle is the actual search area of 200 km byradius.
• The rectangle is the actual search area of 200 km bybox.

Q: How to determine that a point is within the axis-aligned rectangle?

If the coordinates of this point are greater than the minimum latitude and longitude and less than the maximum latitude and longitude.

// x2,y2 is the point, x1, y1 is the search center point. so use x2, y2 and bounds to judge.

int geohashGetDistanceIfInRectangle(double *bounds, double x1, double y1,
                                     double x2, double y2, double *distance) {
     if (x2 <bounds[0] || x2> bounds[2] || y2 <bounds[1] || y2> bounds[3]) return 0;
     *distance = geohashGetDistance(x1, y1, x2, y2);
     return 1;
}

After you suggest that you should use height/2, width/2, I think your opinion is correct and logical.

So in order to reach the search range of the above pictures, the new parameters are as follows:

geosearch Sicily fromloc 15 37 bybox 400 400 km asc

Is that right?

@yangbodong22011 yes, width and height of that box are 400. i'm not aware of a word in English that describes half the width (other than saying half_width), so i guess we need to stick to the terminology of the command syntax, and adjust the code.

updated:

• Modify the position of the bounds variable and add comments to GeoShape.
• Modify the calculation method of radius_meters, remove sqrt, ues the larger of height/2 and width/2.
• GEOSEARCH with STORE|STOREDIST and GEOSEARCHSTORE with STORE means syntax error.
• Add extractBoxOrReply() for parse box
• refactor some function name and modify comment

@oranagra I will close some of the comments in your previous comments, please review again when you have time.

@redis/core-team please approve the new commands and their syntax.

@yangbodong22011 can you please also make a redis-doc PR for this?

@yangbodong22011 can you please also make a redis-doc PR for this?

sure, I will do it.