I'm still not convinced the default behavior should be to create the directory path. I would be open to it being a separate option. Do others have thoughts?

I'm still not convinced the default behavior should be to create the directory path. I would be open to it being a separate option. Do others have thoughts?

you mean we set some config for this?
if user set option to create directory as default behavior, we create it otherwise not?

i don't agree with this merge request. Environment variables should be checked carefully by users themselves if they want to deploy redis. Because redis can't and should not to match so many operating systems!!!

I agree with @madolson about this, I don't think Redis should be doing this kind of setup and it's also not a generally common practice with other similar services. @KhDanial Is there any specific reason you can't just verify that the directory exists and with the right permissions before starting the redis-server process?

BTW this implementation also introduces a security vulnerability as it uses an unbounded strcpy() to copy a user-provided string into a stack buffer.

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}