Skip to content

Clean up building with USE_SYSTEMD.#8073

Merged
yossigo merged 1 commit intoredis:unstablefrom
yossigo:systemd-make-cleanup
Nov 22, 2020
Merged

Clean up building with USE_SYSTEMD.#8073
yossigo merged 1 commit intoredis:unstablefrom
yossigo:systemd-make-cleanup

Conversation

@yossigo
Copy link
Collaborator

@yossigo yossigo commented Nov 21, 2020

When USE_SYSTEMD=yes is specified, try to use pkg-config to determine
libsystemd linker flags. If not found, silently fall back to simply
using "-lsystemd".

We now use a LIBSYSTEMD_LIBS variable so users can explicitly override
it and specify their own library.

If USE_SYSTEMD is unspecified the old behavior of auto-enabling it if
both pkg-config and libsystemd are available is retained.

Fixes #8059

When USE_SYSTEMD=yes is specified, try to use pkg-config to determine
libsystemd linker flags. If not found, silently fall back to simply
using "-lsystemd".

We now use a LIBSYSTEMD_LIBS variable so users can explicitly override
it and specify their own library.

If USE_SYSTEMD is unspecified the old behavior of auto-enabling it if
both pkg-config and libsystemd are available is retained.
@yossigo yossigo requested a review from oranagra November 22, 2020 09:40
@yossigo yossigo merged commit 08d3e92 into redis:unstable Nov 22, 2020
@yossigo yossigo deleted the systemd-make-cleanup branch November 22, 2020 12:40
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Mar 2, 2021
When USE_SYSTEMD=yes is specified, try to use pkg-config to determine
libsystemd linker flags. If not found, silently fall back to simply
using "-lsystemd".

We now use a LIBSYSTEMD_LIBS variable so users can explicitly override
it and specify their own library.

If USE_SYSTEMD is unspecified the old behavior of auto-enabling it if
both pkg-config and libsystemd are available is retained.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] If pkg-config is missing, redis is silently built without systemd support

2 participants