Improve and clean up supervised process support.#8036
Improve and clean up supervised process support.#8036yossigo merged 2 commits intoredis:unstablefrom
Conversation
* Configuration file default should now be "auto". * Expose "process_supervised" as an info field. * Log messages improvements (clarify required systemd config, report auto-detected supervision mode, etc.) * Set server.supervised properly, so it can take precedence of "daemonize" configuration. * Produce clear warning if systemd is detected/requested but executable is compiled without support for it, instead of silently ignoring. * Handle systemd notification error on startup, and turn off supervised mode if it failed.
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
i suppose consensus is needed due to the change of default behavior and also the new info field.
redis.conf
Outdated
| # Note: these supervision methods only signal "process is ready." | ||
| # They do not enable continuous pings back to your supervisor. | ||
| supervised no | ||
| supervised auto |
There was a problem hiding this comment.
that makes the default of redis different than the default of the redis.conf.
the convention used to be that they're the same.
so, let's consider making it the default in redis, and if not, the comment here should probably be improved.
either way, this change the default behavior (of someone using this conf file), so it should maybe be shipped in a major minor version?
There was a problem hiding this comment.
I'm OK with keeping the default no for now but just include a commented out supervised auto to make it more obvious it's needed running under systemd.
There was a problem hiding this comment.
ok, so make that change, and remove the major-decision label and we can merge it.
There was a problem hiding this comment.
Still a major-decision due to INFO field.
oranagra
added
release-notes
|
Are we keeping the default or not? |
|
@madolson Yes default is the same ( |
* Configuration file default should now be "auto". * Expose "process_supervised" as an info field. * Log messages improvements (clarify required systemd config, report auto-detected supervision mode, etc.) * Set server.supervised properly, so it can take precedence of "daemonize" configuration. * Produce clear warning if systemd is detected/requested but executable is compiled without support for it, instead of silently ignoring. * Handle systemd notification error on startup, and turn off supervised mode if it failed.
4 participants
auto-detected supervision mode, etc.)
daemonizeconfiguration. In the pastdaemonizesettings had to be compatible withsupervised(e.g.nofor systemd) which could lead to misconfiguration.is compiled without support for it, instead of silently ignoring.
mode if it failed.
Resolved #8024