Rewritten commands are logged as their original command#8006
Merged
madolson merged 4 commits intoredis:unstablefrom Nov 10, 2020
Merged
Rewritten commands are logged as their original command#8006madolson merged 4 commits intoredis:unstablefrom
madolson merged 4 commits intoredis:unstablefrom
Conversation
madolson
force-pushed
the
slowlow-rewrite
branch
from
4daad47 to
2afa75d
Compare
oranagra
reviewed
Nov 3, 2020
oranagra
reviewed
Nov 3, 2020
Contributor
Author
|
I had the mental model there was two functions that rewrote client arguments, and just didn't realize the third one. Will also test the other cases as well! |
madolson
force-pushed
the
slowlow-rewrite
branch
from
2afa75d to
5768de1
Compare
This was
linked to
issues
Nov 10, 2020
Contributor
Author
|
@oranagra Note, I refactored the code for rewriteClientVector since they do the same thing. The code is verbatim the same, it's just a little confusing since they do it differently. |
oranagra
approved these changes
Nov 10, 2020
oranagra
pushed a commit
that referenced
this pull request
Nov 11, 2020
(this is a fixup for #8006) Co-authored-by: Madelyn Olson <[email protected]>
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 19, 2020
* Rewritten commands are logged as their original command Co-authored-by: Madelyn Olson <[email protected]>
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 19, 2020
(this is a fixup for redis#8006) Co-authored-by: Madelyn Olson <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slowlog emits whatever is on the client argv, which can be rewritten for replication. Note: They are rewritten even when there is no replica, so this occurs on standalone redis instances as well.