Further improved ACL algorithm for picking categories#7966
Merged
madolson merged 2 commits intoredis:unstablefrom Oct 28, 2020
Merged
Further improved ACL algorithm for picking categories#7966madolson merged 2 commits intoredis:unstablefrom
madolson merged 2 commits intoredis:unstablefrom
Conversation
Contributor
Author
|
Also worth asking the question if we should just redo this code path, since it's kind of weird that we try to "rewrite" the categories that were given. |
Member
|
by "redo" you mean to remember the input so that we can emit it on rewrite without re-composing it? |
oranagra
reviewed
Oct 27, 2020
oranagra
approved these changes
Oct 27, 2020
Contributor
Author
|
@oranagra I missed your other comment about altering this code. I didn't really have a suggestion for how we could implement it, I was just thinking I don't really like it. |
Member
|
@madolson you mean the conversation about the "redo"? |
oranagra
added
the
release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built a slight better algorithm that picks categories that are closer to optimal since there were still some basic cases that were producing non-obvious results. Was impacting someone else's PR.
Note, we do need to check both maxsame and mindiff for it to pass the test cases, otherwise several cases fail. e.g.