Add a --no-latency tests flag.#7939
Merged
yossigo merged 2 commits intoredis:unstablefrom Oct 22, 2020
Merged
Conversation
Useful for running tests on systems which may be way slower than usual.
oranagra
previously approved these changes
Oct 21, 2020
tests/integration/replication.tcl
Outdated
| # If running on Linux, we also measure utime/stime to detect possible I/O handling issues | ||
| set os [catch {exec unamee}] | ||
| set measure_time [expr {$os == "Linux"} ? 1 : 0] | ||
| set measure_time [expr {$os == "Linux" && !$::no_latency} ? 1 : 0] |
Member
There was a problem hiding this comment.
I would rather just make the assertions conditional, and keep the verbose logging
Member
|
fresh from the oven: teaches us two things:
|
* Add --no-latency to macos daily. * Print measured replication time with --no-latency. * Ignore another latency assert.
oranagra
approved these changes
Oct 22, 2020
oranagra
pushed a commit
that referenced
this pull request
Oct 27, 2020
Useful for running tests on systems which may be way slower than usual. (cherry picked from commit 843a13e)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
Useful for running tests on systems which may be way slower than usual.
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
Useful for running tests on systems which may be way slower than usual. (cherry picked from commit 843a13e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for running tests on systems which may be way slower than usual.