Fixed bug concerning redis-benchmark non clustered benchmark forcing always the same hash tag {tag}#7931
Merged
oranagra merged 2 commits intoredis:unstablefrom Oct 20, 2020
Conversation
itamarhaber
reviewed
Oct 20, 2020
oranagra
reviewed
Oct 20, 2020
oranagra
reviewed
Oct 20, 2020
…rcing always the same hash tag {tag}
filipecosta90
force-pushed
the
redis.benchmark.stag
branch
from
7f7fd1f to
2f55b93
Compare
filipecosta90
commented
Oct 20, 2020
src/redis-benchmark.c
Outdated
| argv[0] = "MSET"; | ||
| const char *cmd_argv[21]; | ||
| cmd_argv[0] = "MSET"; | ||
| char* key_placeholder = sdscatprintf(sdsnew(""),"key%s:__rand_int__",tag); |
Contributor
Author
There was a problem hiding this comment.
@oranagra as per the PR review, changed to cmd_argv and using only one key_placeholder ( freed on the end )
oranagra
approved these changes
Oct 20, 2020
Member
|
@filipecosta90 please see my commit. |
oranagra
added a commit
that referenced
this pull request
Oct 27, 2020
…always the same hash tag {tag} (#7931)
Adding the ":{tag}" only if --cluster is used, so that when used against
a proxy it generates traffic to all shards.
Co-authored-by: Oran Agra <[email protected]>
(cherry picked from commit 6cf23d6)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
…always the same hash tag {tag} (redis#7931)
Adding the ":{tag}" only if --cluster is used, so that when used against
a proxy it generates traffic to all shards.
Co-authored-by: Oran Agra <[email protected]>
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
…always the same hash tag {tag} (redis#7931)
Adding the ":{tag}" only if --cluster is used, so that when used against
a proxy it generates traffic to all shards.
Co-authored-by: Oran Agra <[email protected]>
(cherry picked from commit 6cf23d6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the issue described in #7930 , this PR fixes it by only including the hash tag placeholder when
--clusterflag is passed.Bellow is a quick example of the impact on a Redis Enterprise POC setup with 4 master shards.
current load pattern of redis-benchmark
fixed load pattern of redis-benchmark