support NOMKSTREAM option in xadd command#7910
Merged
oranagra merged 2 commits intoredis:unstablefrom Oct 18, 2020
Merged
Conversation
oranagra
reviewed
Oct 14, 2020
hwware
force-pushed
the
xadd_nomkstream
branch
2 times, most recently
from
8c21c76 to
398eee5
Compare
madolson
reviewed
Oct 16, 2020
Contributor
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
Otherwise looks good to me, also added the major decision tag.
hwware
force-pushed
the
xadd_nomkstream
branch
from
e0aefe1 to
ca3033c
Compare
madolson
previously approved these changes
Oct 16, 2020
Contributor
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
I'm not sure why the build is broken, but I'm good with this otherwise.
Contributor
Author
|
hi @madolson , the build error seems unrelated, not sure how this happens but it seems like the environment was broken for missing some dependencies.. |
oranagra
approved these changes
Oct 16, 2020
oranagra
added
release-notes
Member
|
@redis/core-team please approve a new XADD flag. |
madolson
approved these changes
Oct 16, 2020
yossigo
approved these changes
Oct 18, 2020
Member
|
@hwware merged. please don't forget the redis-doc PR. |
Contributor
Author
|
@oranagra will do, thanks for the reminder |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
introduces a NOMKSTREAM option for xadd command, this would be useful for some use cases when we do not want to create new stream by default: XADD key [MAXLEN [~|=] <count>] [NOMKSTREAM] <ID or *> [field value] [field value]
18 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a NOMKSTREAM option for xadd command, this would be useful for some use cases when we do not want to create new stream by default:
XADD key [MAXLEN [~|=] <count>] <ID or *> <NOMKSTREAM> [field value] [field value]Fixes: #6204