Delete dbExists() which is redundant.#7906
Merged
oranagra merged 1 commit intoredis:unstablefrom Oct 13, 2020
Merged
Conversation
oranagra
approved these changes
Oct 13, 2020
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
i was actually recently considering to expose it via a module API.
was having a hard time to decide if using it instead of lookupKey is good or bad.
I suppose we better encourage using lookupKey with various flags rather direct dictFind. in most cases it's probably a bug that's overlooked rather than the intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5021 fixed exists command on replica, but it did not delete dbExists(), which is never used after that.