Skip to content

Add some additional signal info to the crash log#7891

Merged
oranagra merged 2 commits intoredis:unstablefrom
oranagra:signal_info
Oct 7, 2020
Merged

Add some additional signal info to the crash log#7891
oranagra merged 2 commits intoredis:unstablefrom
oranagra:signal_info

Conversation

@oranagra
Copy link
Member

@oranagra oranagra commented Oct 7, 2020

  1. si_code can be very useful info some day.
  2. a clear indication that redis was killed by an external user

1. si_code can be very useful info some day.
2. a clear indication that redis was killed by an external user
3. si_addr is also valid for SIGFPE
@oranagra oranagra requested a review from yossigo October 7, 2020 09:59
@oranagra oranagra requested a review from madolson October 7, 2020 15:45
Copy link
Contributor

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oranagra oranagra merged commit f659d23 into redis:unstable Oct 7, 2020
@oranagra oranagra deleted the signal_info branch October 7, 2020 17:29
oranagra added a commit that referenced this pull request Oct 27, 2020
- si_code can be very useful info some day.
- a clear indication that redis was killed by an external user

(cherry picked from commit f659d23)
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Nov 4, 2020
- si_code can be very useful info some day.
- a clear indication that redis was killed by an external user
jschmieg pushed a commit to memKeyDB/memKeyDB that referenced this pull request Nov 6, 2020
- si_code can be very useful info some day.
- a clear indication that redis was killed by an external user

(cherry picked from commit f659d23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants