Fixed excessive categories being displayed from acls#7889
Merged
madolson merged 1 commit intoredis:unstablefrom Oct 8, 2020
Merged
Fixed excessive categories being displayed from acls#7889madolson merged 1 commit intoredis:unstablefrom
madolson merged 1 commit intoredis:unstablefrom
Conversation
oranagra
approved these changes
Oct 7, 2020
Merged
oranagra
pushed a commit
that referenced
this pull request
Oct 27, 2020
(cherry picked from commit 2127f7c)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
(cherry picked from commit 2127f7c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are multiple categories that fix the criteria of "more than half of the commands are in this group, either by inclusion or exclusion," we include all of them. This can result in overlapping categories that require a lot of re-adding or re-removing. For example:
"-@ALL +@READ" -> "-@ALL +@READ +@set +@sortedset +@hash +@bitmap +@geo -sdiffstore -hmset -setbit -hsetnx -zremrangebyscore -zpopmax -spop -sort -zpopmin -hset -georadiusbymember -zremrangebylex -geoadd -sunionstore -bitfield -bzpopmin -sadd -zadd -hdel -zunionstore -bitop -zinterstore -bzpopmax -hincrby -sinterstore -zremrangebyrank -zrem -smove -zincrby -srem -hincrbyfloat -georadius"
Since the set, sortedset, hash, bitmap, and geo categories have a majority of read commands, they all get included, but then need all their write to be removed.
We still might not build the "optimal" string, but we should only build shorter strings after this change.