Support ACL for Sentinel Mode#7888
Merged
oranagra merged 6 commits intoredis:unstablefrom Oct 19, 2020
Merged
Conversation
hwware
force-pushed
the
sentinel_acl
branch
2 times, most recently
from
ba87e7b to
d7b8405
Compare
oranagra
reviewed
Oct 7, 2020
Member
|
@redis/core-team please at least have a quick look and approve the concept / feature (even if you can't afford review the code yet) |
Collaborator
|
Looks good to me. |
oranagra
previously approved these changes
Oct 11, 2020
itamarhaber
previously approved these changes
Oct 11, 2020
yossigo
previously approved these changes
Oct 11, 2020
oranagra
added
the
state:to-be-merged
Member
|
@hwware can you prepare a PR to update the docs? |
Contributor
Author
|
@oranagra @itamarhaber thanks Oran,Itamar, please see the following doc pr redis/redis-doc#1417. Please review. thanks |
madolson
previously approved these changes
Oct 16, 2020
oranagra
added
the
release-notes
hwware
dismissed stale reviews from madolson, yossigo, itamarhaber, and oranagra
via
b64b4b0
Member
|
@hwware please have a look at the commits i added and let me know if they're ok. |
Contributor
Author
|
hi @oranagra , these three changes looks good to me. I think we can merge this now. Please also review the redis/redis-doc#1417 pr and let me know if we need to do more changes on the doc.. Thanks! |
oranagra
approved these changes
Oct 19, 2020
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
This commit implements ACL for Sentinel mode, main work of this PR includes: - Update Sentinel command table in order to better support ACLs. - Fix couple of things which currently blocks the support for ACL on sentinel mode. - Provide "sentinel sentinel-user" and "sentinel sentinel-pass " configuration in order to let sentinel authenticate with a specific user in other sentinels. - requirepass is kept just for compatibility with old config files Co-authored-by: Oran Agra <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements ACL for Sentinel mode, main work of this PR includes:
this should Fix:#7708