Allow blocked XREAD on a cluster replica#7881
Merged
oranagra merged 2 commits intoredis:unstablefrom Oct 6, 2020
oranagra:blocked_xread_on_replica
Merged
Allow blocked XREAD on a cluster replica#7881oranagra merged 2 commits intoredis:unstablefrom oranagra:blocked_xread_on_replica
oranagra merged 2 commits intoredis:unstablefrom
oranagra:blocked_xread_on_replica
Conversation
Contributor
|
I don't see any problem with this, a test would be nice. |
oranagra
added
backport-candidate
release-notes
- add better support for additional (and deferring) clients for cluster tests - improve a test which left the client in MULTI state.
Member
Author
|
@madolson please review. (it suxx how much the cluster tests infra is inferior to the normal test infra) |
Merged
oranagra
added a commit
that referenced
this pull request
Oct 27, 2020
I suppose that it was overlooked, since till recently none of the blocked commands were readonly. other changes: - add test for the above. - add better support for additional (and deferring) clients for cluster tests - improve a test which left the client in MULTI state. (cherry picked from commit 216c110)
oranagra
added a commit
that referenced
this pull request
Oct 27, 2020
I suppose that it was overlooked, since till recently none of the blocked commands were readonly. other changes: - add test for the above. - add better support for additional (and deferring) clients for cluster tests - improve a test which left the client in MULTI state. (cherry picked from commit 216c110)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
I suppose that it was overlooked, since till recently none of the blocked commands were readonly. other changes: - add test for the above. - add better support for additional (and deferring) clients for cluster tests - improve a test which left the client in MULTI state.
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
I suppose that it was overlooked, since till recently none of the blocked commands were readonly. other changes: - add test for the above. - add better support for additional (and deferring) clients for cluster tests - improve a test which left the client in MULTI state. (cherry picked from commit 216c110)
pulllock
pushed a commit
to pulllock/redis
that referenced
this pull request
Jun 28, 2023
I suppose that it was overlooked, since till recently none of the blocked commands were readonly. other changes: - add test for the above. - add better support for additional (and deferring) clients for cluster tests - improve a test which left the client in MULTI state. (cherry picked from commit 216c110)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suppose that it was overlooked, since till recently none of the blocked commands were readonly.
Fixes #7877
Tested manually.
@madolson if you think that i'm going the right way, i'll add a test for that.